Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next: 1.3.4 -> 1.4.0 #79307

Merged
merged 1 commit into from Feb 6, 2020
Merged

next: 1.3.4 -> 1.4.0 #79307

merged 1 commit into from Feb 6, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Feb 6, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/jyp17bxcqc34a427wnrcc9wfnp2b1wqv-next-1.3.4 1017.8M
/nix/store/zs5q9b4flmzpavzn2kx6a2ifpkli59by-next-1.4.0 1.0G

to have an idea to the deps changes (check next.asd or maybe the guix files):
atlas-engineer/nyxt@1.3.4...1.4.0

@ofborg ofborg bot requested a review from nlewo February 6, 2020 04:45
@nlewo
Copy link
Member

nlewo commented Feb 6, 2020

Works locally! Thx.

@nlewo nlewo merged commit 7659e10 into NixOS:master Feb 6, 2020
@bbigras bbigras deleted the next branch February 6, 2020 12:59
@bbigras
Copy link
Contributor Author

bbigras commented Feb 6, 2020

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo Awaiting requested review from nlewo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bbigras @nlewo