Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 301bca073491
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 07281f23b690
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Feb 6, 2020

  1. fwupd: split daemon again 

    In 1.3.5, fwupdprivate library was made into a shared fwupdplugin library.
This library is considered semi-private and is used by fwupd daemon and
fwupd plug-ins and now possibly third party plug-ins.

The fwupdplugin library refers to the plug-in directory in fwupd.out
causing a dependency cycle. For that reason we need to move it to out.
    @jtojnar
    jtojnar committed Feb 6, 2020
    Copy the full SHA
    c942013 View commit details
    Browse the repository at this point in the history

  2. nixos/fwupd: disable test plugins implicitly 

    invalid test was introduced in fwupd/fwupd@297d159
and it is disabled in the shipped daemon.conf.

I forgot to reflect that in the module, which caused the daemon to print the following on start-up:

    FuEngine             invalid has incorrect built version invalid

and the command to warn:

    WARNING: The daemon has loaded 3rd party code and is no longer supported by the upstream developers!

To reduce the change of this happening in the future, I moved the list of default disabled plug-ins to the package expression.

I also set the value of the NixOS module option in the config section of the module instead of the default value used previously,
which will allow users to not care about these plug-ins.
    @jtojnar
    jtojnar committed Feb 6, 2020
    Copy the full SHA
    e5f7dac View commit details
    Browse the repository at this point in the history

  3. Merge pull request #79371 from jtojnar/hughsie-pkgs 

    fwupd: split daemon again
    @jtojnar
    jtojnar committed Feb 6, 2020
    Copy the full SHA
    07281f2 View commit details
    Browse the repository at this point in the history