Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gogs: 0.11.86 -> 0.11.91, fixes CVE-2019-14544 #79314

Merged
merged 1 commit into from Feb 6, 2020
Merged

gogs: 0.11.86 -> 0.11.91, fixes CVE-2019-14544 #79314

merged 1 commit into from Feb 6, 2020

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Feb 6, 2020 •
edited

Motivation for this change

Update and fix for CVE-2019-14544, CVSS 3 Score 9.8

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ehmry February 6, 2020 07:25
@Moredread Moredread mentioned this pull request Feb 6, 2020
Merged
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/91

schneefux
schneefux approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@schneefux schneefux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good, I didn't test binary. Thank you!

lsix
lsix approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built locally. All fine for me.

@lsix lsix merged commit d761fcb into NixOS:master Feb 6, 2020
@Moredread Moredread deleted the gogs-0.11.91 branch February 6, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsix lsix lsix approved these changes

@schneefux schneefux schneefux approved these changes

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Moredread @nixos-discourse @lsix @schneefux