grub: Update extraConfig example text #79406
Conversation
This expands the example to something one might actually want to use to set up a serial console.
benley
added
the
6.topic: nixos
ofborg
bot
added
8.has: module (update)
This expands the example to something one might actually want to use to set up a serial console. (cherry picked from commit 4c5ea02)
| @@ -224,7 +224,11 @@ in | |||
|
|
|||
| extraConfig = mkOption { | |||
| default = ""; | |||
| example = "serial; terminal_output.serial"; | |||
There was a problem hiding this comment.
Was the previous terminal_output.serial actually wrong?
It seems so to me: My grub2 console does not accept terminal_output.serial, only terminal_output.serial (with space instead of dot).
This would be useful to know, because there's still a use of that on current master, here:
nixpkgs/nixos/tests/installer.nix
Line 32 in 44a502b
There was a problem hiding this comment.
Code originally introduced in a65b5ec#r38681077.
There was a problem hiding this comment.
As far as I know terminal_output.serial isn't going to work. That's what led me to writing up this change in the first place - the example didn't work when I tried it, and the grub docs indicated the syntax I replaced it with.
There was a problem hiding this comment.
@benley Would you be up for PRing a fix for the test i linked as well then?
grub.cfg before the menu entries. (This could also be done using `extraEntriesBeforeNixOS', but then you can't have entries *after* the main entry anymore.) * In the installer test, redirect GRUB output to the serial port. svn path=/nixos/branches/boot-order/; revision=22300
It looks like `terminal_output.serial` is incorrect, according to the grub documentation: https://www.gnu.org/software/grub/manual/grub/html_node/Serial-terminal.html Related PR: #79406
| terminal_input --append serial | ||
| terminal_output --append serial |
There was a problem hiding this comment.
Is terminal_input console terminal_output console the default?
I usually have
terminal_input serial console; terminal_output serial console
so I wonder abotu the --append here…
There was a problem hiding this comment.
I was looking at that as well; my understanding from https://www.gnu.org/software/grub/manual/grub/html_node/terminal_005finput.html is that it is good because with --append you can say "also expose it to serial, no matter whether gfxterm or console is the main output".
I haven't actually tried that yet though, that is, I haven't checked whether the combination of gfxterm serial actually works as expected.
There was a problem hiding this comment.
I haven't actually tried that yet though, that is, I haven't checked whether the combination of
gfxterm serialactually works as expected.
I have checked it now, it works.
Motivation for this change
This expands the example to something one might actually want to use to set up a serial console.
(I know this works because I just set up a server using this exact set of options)
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)