Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudflared: 2019.7.0 -> 2019.12.0 #79365

Merged
merged 1 commit into from Feb 8, 2020
Merged

cloudflared: 2019.7.0 -> 2019.12.0 #79365

merged 1 commit into from Feb 8, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Feb 6, 2020

Motivation for this change
Things done

update and switched to buildGoModule

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/905z0jwb2vfdwrkbffg65n8r0wz8qnbs-cloudflared-2019.7.0-bin 53.2M
/nix/store/7zylafshk9h6akb1fh7qjg6ijn1qw7n9-cloudflared-2019.12.0 62.6M

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/93

thoughtpolice
thoughtpolice approved these changes Feb 8, 2020
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@thoughtpolice thoughtpolice merged commit 2104c8b into NixOS:master Feb 8, 2020
@bbigras bbigras deleted the cloudflared branch February 8, 2020 20:05
@bbigras
Copy link
Contributor Author

bbigras commented Feb 8, 2020

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

@ericnorris ericnorris ericnorris approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bbigras @nixos-discourse @thoughtpolice @ericnorris