New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mapproxy: init at 1.12.0 #68628
mapproxy: init at 1.12.0 #68628
Conversation
The test cases are disabled because |
I've done some checks in the source code regarding the usage of libraries. I found that:
So in the example derivation I pasted above, it just has When I tried building locally with {
pkgs ? (import (fetchTarball https://github.com/NixOS/nixpkgs-channels/archive/83e01aa5e48a9107f3b988c9d4c1c21d610626fb.tar.gz) {}),
pythonPath ? "python37"
}:
with pkgs;
let
python = lib.getAttrFromPath (lib.splitString "." pythonPath) pkgs;
in
python.pkgs.buildPythonPackage rec {
pname = "MapProxy";
version = "1.12.0";
src = python.pkgs.fetchPypi {
inherit pname version;
sha256 = "622e3a7796ef861ba21e42231b49c18d00d75f03eaf3f01a2b7687be7568e2ec";
};
propagatedBuildInputs = with python.pkgs; [
pillow
pyyaml
pyproj
shapely
gdal
lxml
];
doCheck = false;
meta = with lib; {
description = "MapProxy is an open source proxy for geospatial data";
homepage = https://mapproxy.org/;
license = licenses.asl20;
maintainers = with maintainers; [ rakesh4g ];
};
} Every works fine. But I use the nix-build ./default.nix --attr pkgs.python3Packages.mapproxy
|
Why would using the call package pattern result in such a difference? Given that my out-of-tree Furthermore this is not the only problem. Even though my
I've reported this problem on mapproxy: mapproxy/mapproxy#424 |
buildInputs = [ | ||
pillow | ||
pyyaml | ||
python3Packages.pyproj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for $python3Packages
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
}; | ||
|
||
prePatch = '' | ||
substituteInPlace mapproxy/util/ext/serving.py --replace "args = [sys.executable] + sys.argv" "args = sys.argv" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throwing away the location of the interpreter seems incorrect to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FRidh , Please suggest what should be the alternate to this. This done to get rid of the problem mapproxy/mapproxy#424
Thanks in advance.
Is there any progress on it? |
I am still waiting on some guidance to alternate options due to |
This can not be merged as is. So we might need to add pyproj version - 1.9.6, With this version Mapproxy works. |
If pyproj 2 is way different from pyproj1, we might need to keep a pyproj1 around in a separate derivation. |
@CMCDragonkai , OK. I will create a new PR to add support for |
Added PR for pyproj1: |
946ed7e
to
4a8725a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, please use an indent width of 2, otherwise the package looks good to me
should be just 1 commit, please squash.
|
ok. |
b3572f1
to
458b19a
Compare
@GrahamcOfBorg build mapproxy |
Hi @jonringer , sorry i made one mistake. it is supposed to be a |
458b19a
to
5e9fcaf
Compare
@GrahamcOfBorg build mapproxy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
executables show usage
has tests 👍
upstream seems somewhat active
[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68628
1 package built:
mapproxy
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @CMCDragonkai