Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.perhaps: jailbreak #79330

Merged
merged 1 commit into from Feb 7, 2020
Merged

haskellPackages.perhaps: jailbreak #79330

merged 1 commit into from Feb 7, 2020

Conversation

Taneb
Copy link
Contributor

@Taneb Taneb commented Feb 6, 2020

Motivation for this change

It has an overly tight dependency on doctest.

Things done

I've made a PR upstream too.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [ x Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cdepillabout
cdepillabout requested changes Feb 7, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to actually mark this as unbroken in the configuration-hackage2nix.yaml file.

I've tested that this can be built, so once you've marked this as unbroken, I will merge it in.

haskellPackages.perhaps: jailbreak
66c3757 
It has an overly tight dependency on doctest.

I've removed it from the list of broken builds in the yaml and I've made
a PR upstream too.
@Taneb
Copy link
Contributor Author

Taneb commented Feb 7, 2020

@cdepillabout thanks for the spot, I've got allowBroken = true in my config so I missed that. I've force-pushed changing the YAML, but I'll leave the regeneration to @peti or whoever's merging haskell-updates.

@cdepillabout cdepillabout merged commit acbff77 into NixOS:haskell-updates Feb 7, 2020
@cdepillabout
Copy link
Member

Thanks for fixing this up. It should be available next time haskell-updates gets an automatic update.

perhaps looks like an interesting library, btw.

@peti
Copy link
Member

peti commented Feb 7, 2020

Yeah, it looks like a typical new addition to the Kmettverse: it's simple, straight-forward, and captures a fundamental concept in a new and unique way. At the same time, it remains a complete mystery how one would ever use that library in a way that makes a practical difference compared to, say, maybe or either.

peti
peti reviewed Feb 7, 2020
View reviewed changes
pkgs/development/haskell-modules/configuration-common.nix
@@ -1389,4 +1389,7 @@ self: super: {
# prettyprinter-1.6.0 fails its doctest suite.
prettyprinter_1_6_0 = dontCheck super.prettyprinter_1_6_0;

# the test suite has an overly tight restriction on doctest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a link here to that upstream PR or issue you filed?

@Taneb Taneb mentioned this pull request Feb 7, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti left review comments

@cdepillabout cdepillabout cdepillabout requested changes

@basvandijk basvandijk Awaiting requested review from basvandijk

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Taneb @cdepillabout @peti