Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.regex 2019.12.20 -> 2020.8.1 #78754

Closed
wants to merge 1 commit into from
Closed

pythonPackages.regex 2019.12.20 -> 2020.8.1 #78754

wants to merge 1 commit into from
+2 −2

Conversation

pingiun
Copy link
Member

@pingiun pingiun commented Jan 29, 2020 •
edited
Loading

Motivation for this change

The black code formatter was broken under the previous regex version and works with this version.

I updated regex because I got this error message from black:

ModuleNotFoundError: No module named 'regex._regex'

Traceback (most recent call last): File "/usr/local/bin/black", line 5, in from black import patched_main File "/nix/store/2mq7rd88rnj3knsg16j3q8x2lg3c0lc2-python3.7-black-19.10b0/lib/python3.7/site-packages/black.py", line 15, in import regex as re File "/nix/store/gf7y6r2fphfp7mp48khs73b3gw7g38lm-python3.7-regex-2019.12.20/lib/python3.7/site-packages/regex/__init__.py", line 1, in from .regex import * File "/nix/store/gf7y6r2fphfp7mp48khs73b3gw7g38lm-python3.7-regex-2019.12.20/lib/python3.7/site-packages/regex/regex.py", line 402, in import regex._regex_core as _regex_core File "/nix/store/gf7y6r2fphfp7mp48khs73b3gw7g38lm-python3.7-regex-2019.12.20/lib/python3.7/site-packages/regex/_regex_core.py", line 21, in import regex._regex as _regex ModuleNotFoundError: No module named 'regex._regex'

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@pingiun
Copy link
Member Author

pingiun commented Jan 29, 2020

Output of nix-shell -p nixpkgs-review --run "nixpkgs-review wip":

7 package failed to build:
python27Packages.secure python37Packages.ibis-framework python38Packages.ibis-framework python38Packages.spacy python38Packages.textacy python38Packages.wordfreq topydo

115 package built:
aws-sam-cli azure-cli backblaze-b2 buku calibre ceph ceph-client cookiecutter csvs-to-sqlite datasette deja-dup duplicity duply errbot fava flexget git-revise home-assistant-cli http-prompt httpie libceph mnemosyne mwic octoprint paperless papis python27Packages.arrow python27Packages.awesome-slugify python27Packages.cookiecutter python27Packages.dateparser python27Packages.django-q python27Packages.guessit python27Packages.jinja2_time python27Packages.maya python27Packages.python-binance rainbowstream python27Packages.rebulk python27Packages.regex python27Packages.stravalib python27Packages.subliminal python27Packages.transformers python37Packages.arrow python37Packages.awesome-slugify python37Packages.backports_functools_lru_cache python37Packages.black python37Packages.cheroot python37Packages.cherrypy python37Packages.dateparser python37Packages.django-q python37Packages.flask-common python37Packages.guessit python37Packages.habanero python37Packages.httpbin python37Packages.hyperkitty python37Packages.ics python37Packages.irc python37Packages.jaraco_collections python37Packages.jaraco_functools python37Packages.jaraco_logging python37Packages.jaraco_text python37Packages.jinja2_time python37Packages.knack python37Packages.mailman-web python37Packages.maya python37Packages.mesa python37Packages.nvchecker python37Packages.portend python37Packages.pyalgotrade python37Packages.pyls-black python37Packages.pytest-black python37Packages.pytest-httpbin python37Packages.python-binance python37Packages.rainbowstream python37Packages.rebulk python37Packages.regex python37Packages.secure python37Packages.spacy python37Packages.stravalib python37Packages.stumpy python37Packages.subliminal python37Packages.tatsu python37Packages.tempora python37Packages.textacy python37Packages.transformers python37Packages.uarray python37Packages.vcrpy python37Packages.wordfreq python37Packages.ws4py python37Packages.zerobin python38Packages.awesome-slugify python38Packages.csvs-to-sqlite python38Packages.dateparser python38Packages.flask-common python38Packages.guessit python38Packages.habanero python38Packages.httpbin python38Packages.knack python38Packages.maya python38Packages.nvchecker python38Packages.papis python38Packages.pytest-httpbin python38Packages.python-binance python38Packages.rebulk python38Packages.regex python38Packages.secure python38Packages.subliminal python38Packages.tatsu python38Packages.transformers python38Packages.vcrpy rapid-photo-downloader samba4Full tribler uberwriter watson webmacs

@ofborg ofborg bot requested a review from abbradar January 29, 2020 09:40
jonringer
jonringer reviewed Jan 29, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message should be:

pythonPackages.regex: 2019.12.20 -> 2020.8.1

@pingiun
pythonPackages.regex 2019.12.20 -> 2020.8.1

Verified

This commit was signed with the committer’s verified signature.
janb87 Jan Bevers
SSH Key Fingerprint: Q4MM1aj9NRNSXhCdudBo4HGT+Bc10rYGmMPZgGbXTTk
Verified
Learn about vigilant mode
a7b8909
@pingiun pingiun force-pushed the update-python-regex branch from 15843ec to a7b8909 Compare January 29, 2020 18:35
@pingiun pingiun changed the title python/regex 2019.12.20 -> 2020.8.1 pythonPackages.regex 2019.12.20 -> 2020.8.1 Jan 29, 2020
@pingiun pingiun requested a review from jonringer January 30, 2020 11:51
@pingiun
Copy link
Member Author

pingiun commented May 2, 2020

LGTM

@risicle
Copy link
Contributor

risicle commented Aug 26, 2020

This has been superseded.

@risicle risicle closed this Aug 26, 2020
@bsima
Copy link
Contributor

bsima commented Dec 4, 2020

This has been superseded.

@risicle: superseded by what?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

@abbradar abbradar

@jonringer jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pingiun @risicle @bsima @jonringer