Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acsccid: 1.1.6 -> 1.1.8 #78776

Merged
merged 1 commit into from Feb 1, 2020
Merged

acsccid: 1.1.6 -> 1.1.8 #78776

merged 1 commit into from Feb 1, 2020

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jan 29, 2020

Motivation for this change

acsccid: 1.1.6 -> 1.1.8

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from roberth January 29, 2020 15:36
@roberth
Copy link
Member

roberth commented Jan 29, 2020

Did you run it?

@mmahut
Copy link
Member Author

mmahut commented Jan 29, 2020

Did you run it?

I'm using it as a plugin, just running it as a binary coredumps, but same for previous version, so I'm not sure if that is a regression.

@mmahut
Copy link
Member Author

mmahut commented Jan 31, 2020

@roberth is it working for you?

@roberth
Copy link
Member

roberth commented Feb 1, 2020

It does work. I've only ever used it as a plugin, so probably not a regression.

@roberth roberth merged commit 6e62b01 into NixOS:master Feb 1, 2020
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@roberth @anna328p
Merge pull request NixOS#78776 from mmahut/acsccid
31dad2b 
acsccid: 1.1.6 -> 1.1.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberth roberth Awaiting requested review from roberth

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmahut @roberth