Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.argparse: init at 1.4.0 #78672

Closed
wants to merge 1 commit into from
Closed

pythonPackages.argparse: init at 1.4.0 #78672

wants to merge 1 commit into from

Conversation

arnoldfarkas
Copy link
Contributor

Motivation for this change

Adding argparse to Python packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jan 28, 2020

Not adding old packages back.

@FRidh FRidh closed this Jan 28, 2020
@arnoldfarkas
Copy link
Contributor Author

Thanks for pointing this out. I actually planned to add powerline-shell after this merged (
https://github.com/NixOS/nixpkgs/compare/master...WorldQuant:wq_powerline-shell?expand=1 which depends on argparse:
https://github.com/b-ryan/powerline-shell/blob/v0.5.4/powerline_shell/__init__.py)

I will follow up on patching in the Nix expression for powerline-shell since the powerline-shell project seems to be abandoned.

@jonringer
Copy link
Contributor

argparse is now maintained in the standard library. No need to package it.

@jonringer
Copy link
Contributor 

$ nix-shell --pure -p python3

[nix-shell:~]$ python
Python 3.7.5 (default, Oct 14 2019, 23:08:55)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import argparse
>>>

@arnoldfarkas
Copy link
Contributor Author

yeah, meanwhile I have found it and patched the source, it's just awaiting pushing upstream (internal process)

@koslambrou koslambrou mentioned this pull request Aug 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arnoldfarkas @FRidh @jonringer