Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cinnamon.updateScript: add updateScript #78729

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

cinnamon.updateScript: add updateScript #78729

wants to merge 2 commits into from

Conversation

mkg20001
Copy link
Member

Motivation for this change

An update script for cinnamon, to make stuff auto-update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mkg20001
mkg20001 commented Jan 28, 2020
View reviewed changes
pkgs/desktops/cinnamon/gh_update/default.nix

let
pkgs = import ../../../../. { };
nixNodePackage = builtins.fetchGit {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could maybe be integrated into nixpkgs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to libsForQt5.callPackage -> mkDerivation

@stale

This comment was marked as outdated.

Sign in to view
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 26, 2020
@worldofpeace
Copy link
Contributor

Do you still need this @mkg20001 ? The main change that needs to be made is it can't use IFD. I'd merge it right away after that

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 26, 2020
@mkg20001
Copy link
Member Author

IFD?

@stale
Copy link

stale bot commented Jun 6, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 6, 2021
@mkg20001 mkg20001 added this to Stale in Cinnamon Nov 18, 2021
@bobby285271
Copy link
Member

IFD?

I don't really know, maybe this is a case of IFD? 🤔

P.s.: Nowadays there is gitUpdater, is it possible to use it (example in #181225)? I guess it should just work for most case 1 with ignoredVersions = "master*";.

Footnotes

  1. Mint themes and icons don't tag releases, and I haven't found upstream git repo for mint-artwork yet. ↩

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 7, 2022
@bobby285271 bobby285271 moved this from Stale to To do in Cinnamon Oct 20, 2022
@mkg20001
Copy link
Member Author

@bobby285271 the problem with some cinnamon packages is that there are no tags, instead there are commits, etc.

basically lots of non-standard behaviour

this pr has been stale for quite a while so feel free to reuse / close

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
@wegank wegank marked this pull request as draft March 20, 2024 14:53
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
Cinnamon
To do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mkg20001 @worldofpeace @bobby285271 @ryantm @wegank