Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{edk2, OVMF}: 201905 -> 201911 #78777

Merged
merged 1 commit into from Feb 16, 2020
Merged

{edk2, OVMF}: 201905 -> 201911 #78777

merged 1 commit into from Feb 16, 2020

Conversation

arcnmx
Copy link
Member

@arcnmx arcnmx commented Jan 29, 2020

Motivation for this change

Update reasons! Closes #56318 (though it has already been updated since).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@arcnmx arcnmx changed the title edk2: 201905 -> 201911 {edk2, OVMF}: 201905 -> 201911 Jan 29, 2020
@arcnmx
Copy link
Member Author

arcnmx commented Jan 29, 2020

The resulting OVMF binary seems to be working well for passing through a GPU to a Windows QEMU VM.

@GrahamcOfBorg build OVMF

JohnAZoidberg
JohnAZoidberg approved these changes Feb 16, 2020
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resulting OVMF binary seems to be working well for passing through a GPU to a Windows QEMU VM.

Awesome, thanks for testing!

@JohnAZoidberg JohnAZoidberg merged commit a65e7d9 into NixOS:master Feb 16, 2020
@arcnmx arcnmx deleted the pr-edk2-201911 branch November 26, 2022 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update EDK2
2 participants
@arcnmx @JohnAZoidberg