Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.xmlrunner: init at 1.7.7 #78695

Closed
wants to merge 1 commit into from
Closed

pythonPackages.xmlrunner: init at 1.7.7 #78695

wants to merge 1 commit into from

Conversation

arnoldfarkas
Copy link
Contributor

Motivation for this change

Make 'xmlrunner' Python package available in Nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer requested changes Jan 28, 2020
View reviewed changes
pkgs/development/python-modules/xmlrunner/default.nix
Comment on lines +4 to +5
pname = "xmlrunner";
version = "1.7.7";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package hasn't seen a release in 5 years.

Plus i think you get the same functionality if you do pytest --junit-xml=path

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me figure out if this package is actually needed in our environment, since I am generating Nix expressions for a large number of pip packages so that the Nix-based environment is equivalent (or better) than the existing one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a dependency of a python-irodsclient:
https://github.com/irods/python-irodsclient/blob/v0.8.2/setup.py

Which I would like to add in an upcoming PR from:
https://github.com/NixOS/nixpkgs/compare/master...WorldQuant:wq_python-irodsclient?expand=1#diff-b1d0e98bcf35fca90fb661d9052e4135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arnoldfarkas @jonringer