pythonPackages.untangle: init at 1.1.1 #78693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingiun
reviewed
Jan 29, 2020
jonringer
reviewed
Jan 29, 2020
| inherit pname version; | ||
| sha256 = "e7cfa1ad57707e6b74cfea8b9fc50f7cbe9bbaf18401cc9d72192002bcd80bcb"; | ||
| }; | ||
|
|
There was a problem hiding this comment.
add tests please
Suggested change
| checkInputs = [ pytest ]; | |
| checkPhase = '' | |
| pytest tests/ | |
| ''; |
looks like you will have to check out from github to pick up tests as well.
Tests are important to make sure the package still works even after bump it's dependencies
There was a problem hiding this comment.
Good point, did not see that tests were simply omitted.
Let me review my other PRs as well and update accordingly.
WorldQuantOS
force-pushed
the
wq_untangle
branch
from
129dd96
to
986f000
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Make 'untangle' Python package available in Nix.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)