sane module: support overriding config files #78773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/l355-epson-wifi-scanner/5543/10 |
romildo
approved these changes
Jan 30, 2020
There was a problem hiding this comment.
Tested with an Epson L355. The configuration.nix contains:
hardware.sane = {
enable = true;
# https://discourse.nixos.org/t/l355-epson-wifi-scanner/5543/8
extraBackends = pkgs.lib.singleton (pkgs.writeTextFile {
name = "epson2.conf";
text = ''
net 192.168.0.129
'';
destination = "/etc/sane.d/epson2.conf";
});
};The output of scanimage:
$ scanimage -L
device `v4l:/dev/video0' is a Noname Integrated_Webcam_HD: Integrate virtual device
device `epson2:net:192.168.0.129' is a Epson PID 08A8 flatbed scanner
ttuegel
approved these changes
Feb 8, 2020
|
@ttuegel Updated, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Currently, sane configuration cannot be overridden, because backends cannot contain colliding files.
This update allows collisions, and takes the latest file in the list of backends.
See https://discourse.nixos.org/t/l355-epson-wifi-scanner/5543/8
This is a bit hacky, but will be very helpful in a first approach, before someone rewrites this module thoroughly.
TODO: This seems like a good canditate for buildEnv. Is it really important that subdirs are not traversed ? The code dates back to 2014-2016, so maybe the reason is just legacy.
/cc @ttuegel, @abbradar for info
Things done