Skip to content

maintainers: add Frostman #78722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2020
Merged

maintainers: add Frostman #78722

merged 1 commit into from
Jan 28, 2020
+6 −0

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Jan 28, 2020 •
edited
Loading

Motivation for this change

I'm recently switched to NixOS on all my servers & homelab and looking forward to become on some packages such as hugo, minecraft-server and etc.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

Sorry, something went wrong.

@Frostman
maintainers: add Frostman

Verified

This commit was signed with the committer’s verified signature.
sikmir Nikolay Korotkiy
GPG key ID: D1DE6D7F693663A5
Verified
Learn about vigilant mode
3ff2f15
@Frostman Frostman requested a review from worldofpeace January 28, 2020 19:03
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 28, 2020
@worldofpeace worldofpeace merged commit 5ec6a25 into NixOS:master Jan 28, 2020
@worldofpeace
Copy link
Contributor

Thanks @Frostman ✨ Hope to see you contributing sometime in the near future.

@Frostman Frostman deleted the maintainers-add-frostman branch January 29, 2020 03:02
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@worldofpeace @anna328p
Merge pull request NixOS#78722 from Frostman/maintainers-add-frostman
7208b2a 
maintainers: add Frostman
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixos-20-03-feature-freeze/5655/20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Frostman @worldofpeace @nixos-discourse