Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appdaemon: 3.0.5 -> 4.0.1 #78734

Merged
merged 2 commits into from Feb 3, 2020
Merged

appdaemon: 3.0.5 -> 4.0.1 #78734

merged 2 commits into from Feb 3, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 28, 2020 •
edited

Only tested if it builds and tested from commandline

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 changed the title Appdaemon appdaemon: 3.0.5 -> 4.0.1 Jan 28, 2020
@ofborg ofborg bot requested review from peterhoeg and dotlambda January 28, 2020 22:59
peterhoeg
peterhoeg reviewed Jan 30, 2020
View reviewed changes
pkgs/development/python-modules/deepdiff/default.nix Outdated

meta = with lib; {
description = "Deep Difference and Search of any Python object/data";
homepage = https://github.com/seperman/deepdiff;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quote the url please.

pkgs/development/python-modules/deepdiff/default.nix Outdated
# skipped tests require murmur module
checkPhase = ''
py.test -k "not test_prep_str_murmur3_64bit and not test_prep_str_murmur3_128bit" tests
'';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have pytestCheckHook that will process disabledTests.

@ofborg ofborg bot requested a review from peterhoeg January 30, 2020 14:49
@peterhoeg peterhoeg merged commit f8c5513 into NixOS:master Feb 3, 2020
@Mic92 Mic92 deleted the appdaemon branch July 23, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@dotlambda dotlambda Awaiting requested review from dotlambda

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @peterhoeg