Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.django: 1.11 -> 2.2 #78711

Closed
wants to merge 7 commits into from
Closed

pythonPackages.django: 1.11 -> 2.2 #78711

wants to merge 7 commits into from
+44 −15

Conversation

lsix
Copy link
Member

@lsix lsix commented Jan 28, 2020

Motivation for this change

Django-1.11 will end its support before in march 2020, so I try to get rid of it before the 20.03 release.

This PR tries to fix most breakages.

This is still a WIP, but I’d like to have it integreated before 20.03 feature freeze, even if I still have some fixing to do after.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@lsix lsix requested review from FRidh and jonringer as code owners January 28, 2020 14:46
@lsix lsix added this to the 20.03 milestone Jan 28, 2020
@lsix lsix changed the title WIP: pythonPackages.django: 1.11 -> 2.2 pythonPackages.django: 1.11 -> 2.2 Feb 3, 2020
@lsix lsix force-pushed the introduce_django_lts branch 2 times, most recently from 7a606ed to 7234157 Compare February 4, 2020 11:48
@lsix
Copy link
Member Author

lsix commented Feb 4, 2020

This PR tends to break multiple packages (among them mailan-web), which is unfortunate.

I would prefer to have then broken “now” and make sure that what we ship can be supported for the lifetime of release-20.03, but that is a personal opinion.

@jonringer @FRidh any thought on that ?

@disassembler disassembler modified the milestones: 20.03, 20.09 Feb 5, 2020
@FRidh
Copy link
Member

FRidh commented Feb 6, 2020

I indeed think this should ship in 20.03 as well. We do need to ensure mailman-web functions, at least in the NixOS module.

@lsix lsix force-pushed the introduce_django_lts branch from 7234157 to 91e34a7 Compare February 6, 2020 17:40
@lsix
Copy link
Member Author

lsix commented Feb 6, 2020

I have updated the definition of mailman-web (in all-packages.nix) to use use django-1.11 (the one used in the module). Hopefully it will be updated to support django-2.2 before django-1.11 reaches EOL (or I’ll do it if I have some time)

@FRidh
Copy link
Member

FRidh commented Feb 6, 2020

cc @alyssais regarding mailman-web

@lsix lsix force-pushed the introduce_django_lts branch from 91e34a7 to 63ad77e Compare February 8, 2020 22:43
@lsix lsix force-pushed the introduce_django_lts branch from 63ad77e to 465e592 Compare February 8, 2020 23:00
@lsix
Copy link
Member Author

lsix commented Feb 8, 2020

I have fixed all django related errors or disabled packages that does not support django-2.2 (yet).

Few errors remain, but only for packages already broken on master.

@lsix
Copy link
Member Author

lsix commented Feb 8, 2020

For the record, still broken packages are:

$ nix-review pr 78711
[…]
6 package failed to build:
python37Packages.google_cloud_error_reporting python37Packages.google_cloud_logging python37Packages.pelican python38Packages.google_cloud_error_reporting python38Packages.google_cloud_logging python38Packages.pelican

139 package built:
[…]

@FRidh
Copy link
Member

FRidh commented Feb 9, 2020

Thank you! I've fixed the evaluation error and pushed the commits to #79375.

@FRidh FRidh closed this Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

@jonringer jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lsix @FRidh @disassembler