Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: 5.4.15 -> 5.5.0 #78704

Closed
wants to merge 1 commit into from
Closed

linux: 5.4.15 -> 5.5.0 #78704

wants to merge 1 commit into from

Conversation

colemickens
Copy link
Member

Motivation for this change

Update linux-stable to 5.5.0since it has been released.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@colemickens
Copy link
Member Author

Should I go ahead and drop 5.4.x?

@Frostman
Copy link
Member

Frostman commented Jan 28, 2020 •
edited

I've tried it using nixpkgs-review tool and got 50+ fails. Here are the first couple of errors:

builder for '/nix/store/yim933vcac3n32hz8fypq34rz69q5a8v-bpftool-5.5.drv' failed with exit code 2; last 10 log lines:

  Auto-detecting system features:
  ...                        libelf: [ on  ]
  ...                           bpf: [ on  ]

  /nix/store/715fljdrspphbdk255r729zxp4w7lcgk-bash-4.4-p23/bin/bash: /build/linux-5.5/scripts/bpf_helpers_doc.py: /usr/bin/python3
: bad interpreter: No such file or directory
  make[1]: *** [Makefile:185: bpf_helper_defs.h] Error 126
  make[1]: *** Deleting file 'bpf_helper_defs.h'
  make[1]: Leaving directory '/build/linux-5.5/tools/lib/bpf'
  make: *** [Makefile:32: /build/linux-5.5/tools/lib/bpf/libbpf.a] Error 2
builder for '/nix/store/bhjvljc8wrcqx3prrs5lygwzc5hyhs56-perf-linux-5.5.drv' failed with exit code 2; last 10 log lines:
    LD       libsubcmd-in.o
    LD       libperf-in.o
    HOSTLD   pmu-events/jevents-in.o
    AR       libsubcmd.a
    AR       libperf.a
    PERF_VERSION = 5.5.0
    LD       libtraceevent-in.o
    LINK     libtraceevent.a
  make[1]: *** [Makefile.perf:225: sub-make] Error 2
  make: *** [Makefile:70: all] Error 2

Just in case, I'm running release-19.09 with the latest kernel. Not sure if it's something with my setup...

@dtzWill
Copy link
Member

dtzWill commented Jan 28, 2020

Ran into few failures, so far they're the same issue manifesting in various kernel-source-based-utilities like perf. Here are fixes I've put together so far, FWIW:

@worldofpeace
Copy link
Contributor

This conflicts with #78713

@vcunat
Copy link
Member

vcunat commented Jan 28, 2020

How so?

@samueldr
Copy link
Member

samueldr commented Jan 28, 2020 •
edited

Should I go ahead and drop 5.4.x?

No! 5.4 is an LTS. We keep all LTS until EOL'd.

EDIT: I should even add, we always init new major kernels, never "upgrade" new major kernel versions, and we only drop at EOL time.

@samueldr
Copy link
Member

cc @NeQuissimus who's been handling kernel updates for a while.

@worldofpeace
Copy link
Contributor

Hmmmmmmm, feels like I'm getting deja vu @colemickens because of ff54d08, and it isn't the first time it happened.
Guess I should close this, sorry about that.

@colemickens colemickens deleted the nixpkgs-linux-5.5 branch January 30, 2020 09:36
@worldofpeace worldofpeace mentioned this pull request Jan 30, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

Assignees
No one assigned
Labels
6.topic: kernel 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@colemickens @Frostman @dtzWill @worldofpeace @vcunat @samueldr