perlPackages.TimeDate: fix tests that fail as of 2020 #78757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 336155c)
|
@GrahamcOfBorg build perlPackages.TimeDate |
mmahut
reviewed
Jan 29, 2020
| @@ -18720,6 +18720,8 @@ let | |||
| url = mirror://cpan/authors/id/G/GB/GBARR/TimeDate-2.30.tar.gz; | |||
| sha256 = "11lf54akr9nbivqkjrhvkmfdgkbhw85sq0q4mak56n6bf542bgbm"; | |||
| }; | |||
| # https://rt.cpan.org/Public/Bug/Display.html?id=124509 | |||
| patches = [ ../development/perl-modules/timedate-2020.patch ]; | |||
There was a problem hiding this comment.
Can we please use fetchPatch from atoomic/perl-TimeDate@4b67ccb ?
There was a problem hiding this comment.
I agree using fetchPatch would be better. However let's do this in a separate PR against master and cherry-pick it here. Ideally most commits in release branches are just cherry picks.
This was referenced Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
TimeDate tests in 19.09 fail as of 2020: https://hydra.nixos.org/job/nixpkgs/nixpkgs-19.09-darwin/perl530Packages.TimeDate.x86_64-darwin.
This has been fixed on master, this PR cherrypicks that change.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)