Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.TimeDate: use fetchpatch instead of storing the patch #78769

Merged
merged 1 commit into from Feb 1, 2020
Merged

perlPackages.TimeDate: use fetchpatch instead of storing the patch #78769

merged 1 commit into from Feb 1, 2020

Conversation

basvandijk
Copy link
Member

Motivation for this change

As requested by @mmahut use fetchpatch to fetch the patch for perlPackages.TimeDate instead of storing it in the repo.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@basvandijk basvandijk mentioned this pull request Jan 29, 2020
Closed
10 tasks
@FRidh
Copy link
Member

FRidh commented Jan 29, 2020

I see no benefit in removing a patch that is already part of our repo.

@basvandijk
Copy link
Member Author

basvandijk commented Jan 29, 2020 •
edited

I think the advantage of fetching a patch from upstream is that it makes it clear that the patch is not a nixpkgs-only thing. It also makes it clear when to remove the patch when you upgrade the package. Namely, when commit atoomic/perl-TimeDate@4b67ccb is merged in the release. With a local patch this takes more work to figure out.

@basvandijk basvandijk merged commit 5ff1a53 into NixOS:staging Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@basvandijk @FRidh