Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc-arm-bin: init at 9.2-2019.12 #78712

Closed
wants to merge 2 commits into from
Closed

gcc-arm-bin: init at 9.2-2019.12 #78712

wants to merge 2 commits into from

Conversation

wamserma
Copy link
Member

Motivation for this change

Provide (official) prebuilt cross-compilers for Arm Cortex-A platform
similar to those for Cortex-R/M provided as gcc-arm-embedded.

Please help with testing, especially on AArch64-hosts.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wamserma
gcc-arm-bin: init at 9.2-2019.12
91f19d3 
Provide (official) prebuilt cross-compilers for Arm Cortex-A platform
similar to those for Cortex-R/M provided as gcc-arm-embedded.
@wamserma
Copy link
Member Author

Ping @prusnak as maintainer of the gcc-arm-embedded packages.

Mic92
Mic92 reviewed Apr 17, 2020
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -8232,6 +8232,13 @@ in
gcc-arm-embedded-9 = callPackage ../development/compilers/gcc-arm-embedded/9 {};
gcc-arm-embedded = gcc-arm-embedded-9;

gcc-arm-bin-9 = { target } : callPackage ../development/compilers/gcc-arm-bin/9 { target = target; };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between the precompiled ones and pkgsCross.armv7l-hf-multiplatform.buildPackages.gcc?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The precompiled ones are sort of "golden reference" versions provided by Arm (regarding exact compiler version, flags etc.). Some projects (e.g. OP-TEE) would download them, but I'm more comfortable with keeping such stuff in the nix store instead of copies cluttering my home.

@Mic92 Mic92 requested a review from Ericson2314 April 17, 2020 14:08
@Ericson2314
Copy link
Member

Ericson2314 commented Apr 17, 2020 •
edited

I can't say I am a big fan of this. @matthewbauer did good work removing rebuilt GCCs and proving nice platform cross support. Is there a problem with the cross compilers we build from source?

@wamserma
Copy link
Member Author

I can't say I am a big fan of this. Is there a problem with the cross compilers we build from source?

No, absolutely not. Would you suggest moving this to NUR instead?

@Mic92
Copy link
Member

Mic92 commented Apr 17, 2020 •
edited

@wamserma In case you do put in NUR, you can drop a link in https://nixos.wiki/wiki/Cross_Compiling for better discovery.

@wamserma
Copy link
Member Author

wamserma commented May 4, 2020

Moved the PR here: wamserma/nur-packages#2, so anyone still interested can pick it up from there.
@Mic92 given the current state of the build (issues with cachix and patchelf), I will not put this in the Wiki yet.

@wamserma wamserma closed this May 4, 2020
@wamserma wamserma deleted the init-gcc-arm-bin branch May 4, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wamserma @Ericson2314 @Mic92