Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulkan: 1.1 -> 1.2 #78746

Merged
merged 6 commits into from Feb 11, 2020
Merged

vulkan: 1.1 -> 1.2 #78746

merged 6 commits into from Feb 11, 2020

Conversation

Ralith
Copy link
Contributor

@Ralith Ralith commented Jan 29, 2020

Motivation for this change

Broad ecosystem update for the minor version bump. Definitely want this for the next NixOS release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ralith Ralith mentioned this pull request Jan 29, 2020
Closed
@pingiun
Copy link
Member

pingiun commented Jan 30, 2020

#78746
3 package failed to build:
libretro.atari800 libretro.hatari libretro.play

101 package built:
celluloid curseradio deepin.dde-file-manager deepin.deepin-movie-reborn deepin.startdde dolphinEmuMaster glslang kodiPlugins.steam-launcher libplacebo libretro._4do libretro.beetle-gba libretro.beetle-lynx libretro.beetle-ngp libretro.beetle-pce-fast libretro.beetle-pcfx libretro.beetle-psx libretro.beetle-saturn libretro.beetle-snes libretro.beetle-supergrafx libretro.beetle-vb libretro.beetle-wswan libretro.bluemsx libretro.bsnes-mercury libretro.desmume libretro.desmume2015 libretro.dolphin libretro.dosbox libretro.fba libretro.fceumm libretro.flycast libretro.gambatte libretro.genesis-plus-gx libretro.gpsp libretro.handy libretro.higan-sfc libretro.mame libretro.mame2000 libretro.mame2003 libretro.mame2003-plus libretro.mame2010 libretro.mame2015 libretro.mame2016 libretro.mesen libretro.mgba libretro.mupen64plus libretro.nestopia libretro.o2em libretro.parallel-n64 libretro.pcsx_rearmed libretro.picodrive libretro.ppsspp libretro.prboom libretro.prosystem libretro.quicknes libretro.scummvm libretro.snes9x libretro.snes9x2002 libretro.snes9x2005 libretro.snes9x2010 libretro.stella libretro.vba-m libretro.vba-next libretro.vecx libretro.virtualjaguar libretro.yabause linux-steam-integration lutris lutris-free lutris-unwrapped minitube mpc-qt mpv mpv-with-scripts openxr-loader pipelight playonlinux plex-media-player python37Packages.mpv python38Packages.mpv renderdoc retroarch retroarchBare rpcs3 shaderc steam steam-run steam-run-native steamcmd vkquake vulkan-headers vulkan-loader vulkan-tools vulkan-validation-layers wine wine-staging winePackages.base winePackages.staging wineWowPackages.base wineWowPackages.full wineWowPackages.staging winetricks

@Ralith
Copy link
Contributor Author

Ralith commented Feb 2, 2020

3 package failed to build:
libretro.atari800

libretro/libretro-core.c: In function 'retro_get_system_info':
libretro/libretro-core.c:575:36: error: expected ';' before 'GIT_VERSION'
  575 |    info->library_version  = "3.1.0" GIT_VERSION;
      |                                    ^~~~~~~~~~~~
      |                                    ;

Looks like unrelated breakage in libretro itself to me.

@Ralith
Copy link
Contributor Author

Ralith commented Feb 8, 2020

Patch release applied. Bump?

@pingiun
Copy link
Member

pingiun commented Feb 9, 2020

lgtm

@FRidh FRidh merged commit ad1934b into NixOS:master Feb 11, 2020
@FRidh
Copy link
Member

FRidh commented Feb 11, 2020

If you think this should go into 20.03, please open a PR against release-20.03.

@worldofpeace
Copy link
Contributor

Same.

@Ralith Ralith deleted the vulkan-1.2 branch February 11, 2020 18:14
@Ralith Ralith mentioned this pull request Feb 11, 2020
Merged
10 tasks
@Ralith
Copy link
Contributor Author

Ralith commented Feb 11, 2020

Backport opened at #79852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ralith @pingiun @FRidh @worldofpeace