Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesos: Fix insecure Maven domain #78703

Closed
wants to merge 1 commit into from
Closed

mesos: Fix insecure Maven domain #78703

wants to merge 1 commit into from

Conversation

jpgu-epam
Copy link

@jpgu-epam jpgu-epam commented Jan 28, 2020 •
edited by veprbl

Motivation for this change

Maven insecure domain was changed.
Closes: #78702

Things done

Fix Maven insecure domain for mesos derivation.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • [*] macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • [ *] Fits CONTRIBUTING.md.

@jpgu-epam jpgu-epam mentioned this pull request Jan 28, 2020
Closed
@ikervagyok
Copy link
Contributor

@jpgu-epam why not simply change http to https? Would be a better fix in the long run.

@jpgu-epam
Copy link
Author

@jpgu-epam why not simply change http to https? Would be a better fix in the long run.

I agree with you but I don't know what this can affects, because why wasn't it over https already?

My guess here is we are trying to include those environments without https support.

@veprbl
Copy link
Member

veprbl commented Jan 28, 2020

@jpgu-epam Please target the "master" branch instead of "nixos-19.09".

@veprbl veprbl added 9.needs: port to stable A PR needs a backport to the stable release. 6.topic: reproducible builds labels Jan 28, 2020
@jpgu-epam jpgu-epam changed the base branch from nixos-19.09 to master January 29, 2020 10:37
@jpgu-epam jpgu-epam changed the base branch from master to nixos-19.09 January 29, 2020 10:38
@jpgu-epam jpgu-epam mentioned this pull request Jan 29, 2020
Closed
10 tasks
@jpgu-epam
Copy link
Author

Closed on favor of #78764

@jpgu-epam jpgu-epam closed this Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: emacs 6.topic: erlang 6.topic: fetch 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: lua 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: policy discussion 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: reproducible builds 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: steam 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation 8.has: module (update) 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jpgu-epam @ikervagyok @veprbl @Janik-Haag