Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.TimeDate: use fetchpatch instead of storing the patch #78765

Closed
wants to merge 1 commit into from
Closed

perlPackages.TimeDate: use fetchpatch instead of storing the patch #78765

wants to merge 1 commit into from

Conversation

basvandijk
Copy link
Member

Motivation for this change

As requested by @mmahut use fetchpatch to fetch the patch for perlPackages.TimeDate instead of storing it in the repo.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@basvandijk
Copy link
Member Author

@GrahamcOfBorg build perlPackages.TimeDate

@basvandijk basvandijk requested review from mmahut and knl January 29, 2020 10:49
@basvandijk basvandijk mentioned this pull request Jan 29, 2020
Merged
10 tasks
@basvandijk
Copy link
Member Author

Oh better to merge this to staging.

@basvandijk
Copy link
Member Author

Closing in favor of #78769.

@basvandijk basvandijk closed this Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut Awaiting requested review from mmahut

@knl knl Awaiting requested review from knl

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@basvandijk