Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] opensmtpd: apply patch for CVE-2020-7247.patch #78752

Merged
merged 1 commit into from Jan 29, 2020
Merged

[19.09] opensmtpd: apply patch for CVE-2020-7247.patch #78752

merged 1 commit into from Jan 29, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jan 29, 2020

Backport the fix included in the bump from 6.6.1p1 -> 6.6.2p1.

Master PR: #78741

Motivation for this change

CVE-2020-7247

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
opensmtpd: apply patch for CVE-2020-7247.patch
f5c74e6 
Backport the fix included in the bump from 6.6.1p1 -> 6.6.2p1.

Master PR: NixOS#78741
@flokli
Copy link
Contributor Author

flokli commented Jan 29, 2020

@GrahamcOfBorg test opensmtpd

@flokli flokli mentioned this pull request Jan 29, 2020
Merged
10 tasks
@flokli flokli changed the title opensmtpd: apply patch for CVE-2020-7247.patch [19.09] opensmtpd: apply patch for CVE-2020-7247.patch Jan 29, 2020
picnoir
picnoir approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@picnoir picnoir left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@ofborg ofborg bot requested review from rickynils and obadz January 29, 2020 08:45
@obadz obadz merged commit e4105b5 into NixOS:release-19.09 Jan 29, 2020
@obadz
Copy link
Contributor

obadz commented Jan 29, 2020

Thanks @flokli

@obadz
Copy link
Contributor

obadz commented Jan 29, 2020

For those who don't want to wait for the channel to move forward:

export NIX_PATH='nixpkgs=https://github.com/NixOS/nixpkgs/archive/e4105b542a0c6828d24e99494ae8b434616429e6.tar.gz:nixos-config=/etc/nixos/configuration.nix'
nixos-rebuild switch/boot/...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnoir picnoir picnoir approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@lheckemann lheckemann Awaiting requested review from lheckemann

@Ekleog Ekleog Awaiting requested review from Ekleog

@globin globin Awaiting requested review from globin

@rickynils rickynils Awaiting requested review from rickynils

@obadz obadz Awaiting requested review from obadz

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @obadz @picnoir