Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 315642ae701f
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 28f2dcc8b741
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jan 29, 2020

  1. pkgs/coreutils: Disable the df skip-rootfs test

    In the sandbox built for https://nixbuild.net, the coreutils build fails
    because a failure in the df skip-rootfs test. The test failure is triggered by
    the existance of a rootfs file system. However, I think that the test is faulty,
    and I have reported it upstream in
    https://lists.gnu.org/archive/html/bug-coreutils/2019-12/msg00000.html.
    
    Disabling the test makes the coreutils build work in the nixbuild.net sandbox,
    and I can't think of any negative impact disabling it can have. In normal nix
    setups and in the normal nix sandbox, this test is not exercised anyway, since
    there is no rootfs visible.
    rickynils authored and FRidh committed Jan 29, 2020

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    cole-h Cole Helbling
    Copy the full SHA
    28f2dcc View commit details
Showing with 4 additions and 0 deletions.
  1. +4 −0 pkgs/tools/misc/coreutils/default.nix
4 changes: 4 additions & 0 deletions pkgs/tools/misc/coreutils/default.nix
Original file line number Diff line number Diff line change
@@ -52,6 +52,10 @@ stdenv.mkDerivation (rec {
sed '2i print "Skipping env -S test"; exit 77;' -i ./tests/misc/env-S.pl
# Fails on systems with a rootfs. Looks like a bug in the test, see
# https://lists.gnu.org/archive/html/bug-coreutils/2019-12/msg00000.html
sed '2i print "Skipping df skip-rootfs test"; exit 77' -i ./tests/df/skip-rootfs.sh
# these tests fail in the unprivileged nix sandbox (without nix-daemon) as we break posix assumptions
for f in ./tests/chgrp/{basic.sh,recurse.sh,default-no-deref.sh,no-x.sh,posix-H.sh}; do
sed '2i echo Skipping chgrp && exit 77' -i "$f"