Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pywick: init at 0.5.6 #78733

Merged
merged 2 commits into from Feb 15, 2020
Merged

python3Packages.pywick: init at 0.5.6 #78733

merged 2 commits into from Feb 15, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Jan 28, 2020 •
edited

python3Packages.hickle: init at 3.4.5

Motivation for this change
Things done

Add a package.

Package hickle has a test dependency on astropy<3.1 which I have lifted since Nixpkgs contains astropy==4.0. The tests pass, but this doesn't mean that I warrant that all astropy data can be used with this package.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [NA] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin
Copy link
Member Author

Pytorch is still not building on Hydra, but this builds fine locally rebasing onto master.

jonringer
jonringer approved these changes Feb 15, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM

failure is due to python3.8 pytorch is broken.

[1 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/s8439937pka26vhc00a1zrzwylpiq3zf-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/78733
1 package failed to build:
python38Packages.pywick

3 package built:
python37Packages.hickle python37Packages.pywick python38Packages.hickle

@jonringer jonringer merged commit 6dca907 into NixOS:master Feb 15, 2020
@bcdarwin bcdarwin deleted the pywick branch February 16, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bcdarwin @jonringer