Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.gunicorn: add setuptools #78727

Merged
merged 1 commit into from
Jan 31, 2020
Merged

python3Packages.gunicorn: add setuptools #78727

merged 1 commit into from
Jan 31, 2020
+14 −4

Conversation

DavHau
Copy link
Member

@DavHau DavHau commented Jan 28, 2020

Motivation for this change

Bugfix is cherry-picked from master.
Execution of gunicorn binary was broken because of missing runtime dependency setuptools.
The other binary gunicorn_paster does still not work, because some other missing dependency. But the gunicorn_paster binary is already removed in the next gunicorn version which is used on master. Therefore I decided to not put any effort into fixing gunicorn_paster

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@DavHau DavHau requested a review from FRidh as a code owner January 28, 2020 19:46
marsam
marsam suggested changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should point to the branch release-19.09, and please use git cherry-pick the flag -x

@jonringer @DavHau
python3Packages.gunicorn: add setuptools

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mweinelt Martin Weinelt
GPG key ID: BD4AA0528F63F17E
Expired
Verified
Learn about vigilant mode
24a0d1d 
(cherry picked from commit 353c83a)
@DavHau DavHau force-pushed the nixos-19.09-bugfix-gunicorn branch from 9646bf8 to 24a0d1d Compare January 30, 2020 16:40
@DavHau DavHau changed the base branch from nixos-19.09 to release-19.09 January 30, 2020 16:41
@DavHau DavHau requested a review from marsam January 30, 2020 16:43
@marsam marsam merged commit 6f61113 into NixOS:release-19.09 Jan 31, 2020
@marsam
Copy link
Contributor

marsam commented Jan 31, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

@marsam marsam

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DavHau @marsam @jonringer