New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smartmontools: fix missing hostname in notifications #82817
Merged
infinisil
merged 2 commits into
NixOS:master
from
pacien:smartd-fix-hostname-notifications
Aug 22, 2020
Merged
smartmontools: fix missing hostname in notifications #82817
infinisil
merged 2 commits into
NixOS:master
from
pacien:smartd-fix-hostname-notifications
Aug 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacien
changed the title
smartd: fix missing hostname in notifications
smartmontools: fix missing hostname in notifications
Mar 18, 2020
pacien
force-pushed
the
smartd-fix-hostname-notifications
branch
from
March 18, 2020 00:21
72e9237
to
0a83242
Compare
pacien
force-pushed
the
smartd-fix-hostname-notifications
branch
from
August 7, 2020 12:44
0a83242
to
90bc8ba
Compare
Rebased to solve conflict. |
Result of 7 package are marked as broken and were skipped:
1 package were blacklisted:
12 package failed to build:
70 package were built:
The deepin packages failures seems to be completely unrelated to smartmontools, but a go packaging issue, there are several errors like this:
Otherwise, checked the |
jtojnar
reviewed
Aug 16, 2020
This properly registers some missing dependencies of smartd_warning.sh.
This makes the notification script use the subject generated by smartmontools itself both for consistency with other distros and to include the hostname.
pacien
force-pushed
the
smartd-fix-hostname-notifications
branch
from
August 16, 2020 18:50
90bc8ba
to
ea37c9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This properly registers some missing dependencies of smartd_warning.sh
and sets the sender's hostname in notification emails.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)