Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeval: don't include huge schema to save space in hydra #82816

Merged
merged 1 commit into from Mar 18, 2020
Merged

kubeval: don't include huge schema to save space in hydra #82816

merged 1 commit into from Mar 18, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 17, 2020 •
edited

kubeval-schema is a huge 7GB repository that we do not want
to build on hydra. Therefore make it optional.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Mar 17, 2020

cc @nicknovitski

@Mic92 Mic92 changed the title kubeval: don't build against schema by default kubeval: don't include huge schema to save space in hydra Mar 17, 2020
@ofborg ofborg bot requested a review from kalbasit March 17, 2020 23:52
@Mic92
kubeval: don't build against schema by default
9d144b8 
kubeval-schema is a huge 7GB repository that we do not want
to build on hydra. Therefore make it optional.
@Mic92 Mic92 merged commit 52ee55f into NixOS:master Mar 18, 2020
@Mic92 Mic92 deleted the kubeval branch March 18, 2020 10:52
@johanot
Copy link
Contributor

johanot commented May 4, 2020

@Mic92 Good fix! Can we perhaps backport this to stable to get a non-broken kubeval in 20.03? :)

@Mic92
Copy link
Member Author

Mic92 commented May 4, 2020

@johanot can you make a PR?

@johanot
Copy link
Contributor

johanot commented May 4, 2020

Sure!

@johanot johanot mentioned this pull request May 4, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @johanot @veprbl