Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visualvm: 1.4.4 -> 2.0 #82842

Merged
merged 2 commits into from Mar 19, 2020
Merged

visualvm: 1.4.4 -> 2.0 #82842

merged 2 commits into from Mar 19, 2020

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Mar 18, 2020 •
edited

Motivation for this change

update!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from michalrus and moaxcp March 18, 2020 11:21
jonringer
jonringer approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I think these should be squashed. Otherwise LGTM

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82842
1 package built:
visualvm

@zimbatm zimbatm merged commit 8edcbd5 into NixOS:master Mar 19, 2020
@zimbatm zimbatm deleted the visualvm-2.0 branch March 19, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@michalrus michalrus Awaiting requested review from michalrus

@moaxcp moaxcp Awaiting requested review from moaxcp

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zimbatm @jonringer