Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncthing: 1.3.4 -> 1.4.0 #82822

Merged
merged 1 commit into from Mar 19, 2020
Merged

syncthing: 1.3.4 -> 1.4.0 #82822

merged 1 commit into from Mar 19, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 18, 2020

Motivation for this change

Changelog: https://github.com/syncthing/syncthing/releases/tag/v1.4.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

andrew-d
andrew-d reviewed Mar 18, 2020
View reviewed changes
Copy link
Contributor

@andrew-d andrew-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the releases, and it seems reasonable to me; the only change that might affect us is the monitor process and how that interacts with the NixOS module, but I don't think it should. I'm not near a machine with syncthing right now - it'd be great if someone could test to confirm.

@emmanuelrosa
Copy link
Contributor

I tested syncing with the Android Syncthing client, which is currently at version 1.3.4, and it worked fine. Everything seems normal :)

The log indicates that an upgrade was detected, so it took some additional steps. I haven't noticed any changes due to the monitor process.

syncthing v1.4.0 "Fermium Flea" (go1.14 linux-amd64) nix@nix 1970-01-01 00:00:01 UTC
Archiving a copy of old config file format at: /var/lib/syncthing/.config/syncthing/config.xml.v29
No automatic upgrades; STNOUPGRADE environment variable defined.
My ID: ***
Single thread SHA256 performance is 270 MB/s using minio/sha256-simd (183 MB/s using crypto/sha256).
Hashing performance is 234.15 MB/s
Migrating database to schema version 9...
Compacting database after migration...
Detected upgrade from v1.3.4 to v1.4.0
Overall send rate is unlimited, receive rate is unlimited

@marsam marsam merged commit 7cf2a62 into NixOS:master Mar 19, 2020
@marsam marsam deleted the update-syncthing branch March 19, 2020 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-d andrew-d andrew-d left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@jokogr jokogr Awaiting requested review from jokogr

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @emmanuelrosa @andrew-d