Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tailscale: 0.96-33 -> 0.97-0. #82824

Merged
merged 1 commit into from Mar 18, 2020
Merged

tailscale: 0.96-33 -> 0.97-0. #82824

merged 1 commit into from Mar 18, 2020

Conversation

danderson
Copy link
Contributor

Motivation for this change

Simple package update.

0.97-0 fixes a severe bug with subnet routing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danderson
tailscale: 0.96-33 -> 0.97-0.
f61f686 
Fixes a severe bug with subnet routing.

Signed-off-by: David Anderson <dave@natulte.net>
@ofborg ofborg bot requested a review from kalbasit March 18, 2020 05:59
@danderson danderson mentioned this pull request Mar 18, 2020
Closed
cole-h
cole-h approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ran tailscale netcheck and it printed out stuff. My nearest DERP is San Fran, it claims.

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82824
1 package built:
tailscale

@alyssais alyssais merged commit 1e59307 into NixOS:master Mar 18, 2020
@danderson danderson deleted the tailscale-0.97 branch March 18, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danderson @cole-h @alyssais