Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rethinkdb: 2.3.6 -> 2.3.7 #82788

Closed
wants to merge 3 commits into from
Closed

rethinkdb: 2.3.6 -> 2.3.7 #82788

wants to merge 3 commits into from

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Mar 17, 2020 •
edited

Motivation for this change

Making this package work. Not upgrading to 2.4.0 because I have no idea how to make 2.4.0 work with Nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska
Copy link
Member Author

@GrahamcOfBorg build rethinkdb python27Packages.rethinkdb python37Packages.rethinkdb python38Packages.rethinkdb

1 similar comment
@KamilaBorowska
Copy link
Member Author

@GrahamcOfBorg build rethinkdb python27Packages.rethinkdb python37Packages.rethinkdb python38Packages.rethinkdb

@KamilaBorowska
Copy link
Member Author

@GrahamcOfBorg build rethinkdb python27Packages.rethinkdb python37Packages.rethinkdb python38Packages.rethinkdb

@KamilaBorowska
Copy link
Member Author

Doesn't work.

@matthias-t
Copy link
Contributor

Just saw this now, but two weeks ago I got this to work in #87828. @xfix, would you be willing to try it out and leave a review? You might also be interested in the following issue that I submitted upstream: rethinkdb/rethinkdb#6867.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@bluescreen303 bluescreen303 Awaiting requested review from bluescreen303

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KamilaBorowska @matthias-t