Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildGoModule: enable strictDeps #82787

Merged
merged 8 commits into from Mar 18, 2020
Merged

buildGoModule: enable strictDeps #82787

merged 8 commits into from Mar 18, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 17, 2020 •
edited

This will improve cross compiling in the long run.
See also #82786

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ericson2314
Copy link
Member

@Mic92 teeny nit I feel bad saying, but I think normally nativeBuildInputs are before buildInputs?

@Mic92
Copy link
Member Author

Mic92 commented Mar 17, 2020

@Mic92 teeny nit I feel bad saying, but I think normally nativeBuildInputs are before buildInputs?

swapped.

@Mic92 Mic92 marked this pull request as ready for review March 17, 2020 23:49
@Mic92
Copy link
Member Author

Mic92 commented Mar 17, 2020

All packages now build for me.

@Mic92 Mic92 merged commit 8590ddd into NixOS:master Mar 18, 2020
@Mic92
Copy link
Member Author

Mic92 commented Mar 18, 2020

Looks like staging is not really required for this one.

@Mic92 Mic92 deleted the cross-build-go-module branch March 18, 2020 13:16
@marsam marsam mentioned this pull request Mar 21, 2020
Merged
10 tasks
@matthewbauer
Copy link
Member

A few macOS things broke from this:

https://hydra.nixos.org/eval/1576403#tabs-now-fail

I'm not actually sure why, but it looks like they are all missing Security framework.

@Mic92
Copy link
Member Author

Mic92 commented Mar 23, 2020

@matthewbauer Oh. Do you have a solution for this or should we disable it on macOS for the time being?

@Mic92
Copy link
Member Author

Mic92 commented Mar 23, 2020

Seems to be fixed by https://github.com/NixOS/nixpkgs/pull/83099/files

@Mic92
Copy link
Member Author

Mic92 commented Mar 23, 2020

Sorry for the breakage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
6.topic: golang 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @Ericson2314 @matthewbauer