Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hyperrogue: 11.2d -> 11.3f #82798

Merged
merged 2 commits into from Apr 2, 2020
Merged

hyperrogue: 11.2d -> 11.3f #82798

merged 2 commits into from Apr 2, 2020

Conversation

mehlon
Copy link
Contributor

@mehlon mehlon commented Mar 17, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mehlon
Copy link
Contributor Author

mehlon commented Mar 17, 2020

Waiting for zenorogue/hyperrogue#98
I've had trouble compiling this, so I'm hoping the CI can confirm if this builds.

@mehlon mehlon marked this pull request as ready for review March 29, 2020 17:49
@mehlon mehlon changed the title hyperrogue: 11.2d -> 11.3a hyperrogue: 11.2d -> 11.3f Mar 29, 2020
@alyssais alyssais merged commit 1d2f6c7 into NixOS:master Apr 2, 2020
@mehlon mehlon deleted the hyperrogue branch April 2, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mehlon @alyssais