Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔋Revise "softmax-regression-scratch_vn" - Phần 1 #969

Merged
merged 8 commits into from Mar 18, 2020
Merged

🔋Revise "softmax-regression-scratch_vn" - Phần 1 #969

merged 8 commits into from Mar 18, 2020

Conversation

thanhcsf
Copy link
Member

Close #919

@thanhcsf thanhcsf added this to the 03. Linear Neural Networks milestone Mar 14, 2020
@thanhcsf thanhcsf added this to Review in progress in v0.14.x via automation Mar 14, 2020
tiepvupsu
tiepvupsu reviewed Mar 15, 2020
View reviewed changes
Copy link
Collaborator

@tiepvupsu tiepvupsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cảm ơn đồng chí.

chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
@thanhcsf @tiepvupsu
Apply suggestions from code review
eee2d23 
Co-Authored-By: tiepvupsu <vuhuutiep@gmail.com>
@thanhcsf thanhcsf marked this pull request as ready for review March 15, 2020 10:46
lkhphuc
lkhphuc reviewed Mar 15, 2020
View reviewed changes
Copy link
Member

@lkhphuc lkhphuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L83: Cụ thể hơn, ta đang phân bổ bộ nhớ để lưu trữ các gradient trong tương lai và cho MXNet biết rằng ta sẽ muốn tính các gradient theo các tham số này trong tương lai.
-> Cụ thể hơn, ta cho MXNet biết rằng ta sẽ muốn tính các gradient theo các tham số này và cần phân bổ bộ nhớ để lưu trữ chúng trong tương lai.

chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
@thanhcsf @lkhphuc
Apply suggestions from code review
d109b3a 
Co-Authored-By: Phúc Lê <phuc.lkh@gmail.com>
ngcthuong
ngcthuong reviewed Mar 16, 2020
View reviewed changes
Copy link
Contributor

@ngcthuong ngcthuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cảm ơn bài revise. Mình có một số comments. Em tham khảo nhé.

chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Show resolved Hide resolved
chapter_linear-networks/softmax-regression-scratch_vn.md Outdated Show resolved Hide resolved
thanhcsf and others added 5 commits March 17, 2020 19:40
@thanhcsf @ngcthuong
Apply suggestions from code review
5057231 
Co-Authored-By: Thuong Nguyen <ngcthuong@skku.edu>
@thanhcsf @ngcthuong
Apply suggestions from code review
7a555f2 
Co-Authored-By: Thuong Nguyen <ngcthuong@skku.edu>
Update 10928
a723f20
Update 10928-2
e7fe91b
@thanhcsf @tiepvupsu
Apply suggestions from code review
88b24e8 
Co-Authored-By: tiepvupsu <vuhuutiep@gmail.com>
ngcthuong
ngcthuong approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@ngcthuong ngcthuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mình thấy ổn rồi. Cảm ơn em

v0.14.x automation moved this from Review in progress to Reviewer approved Mar 18, 2020
@tiepvupsu tiepvupsu merged commit 456ad05 into master Mar 18, 2020
v0.14.x automation moved this from Reviewer approved to Done Mar 18, 2020
@tiepvupsu tiepvupsu deleted the thanhdoan-revise-srs-10928 branch March 18, 2020 05:18
thanhcsf added a commit that referenced this pull request Sep 13, 2020
@thanhcsf
🔋Revise "softmax-regression-scratch_vn" - Phần 1 (#969)
03660a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkhphuc lkhphuc lkhphuc left review comments

@minhduc0711 minhduc0711 minhduc0711 left review comments

@tiepvupsu tiepvupsu tiepvupsu approved these changes

@ngcthuong ngcthuong ngcthuong approved these changes

Assignees
No one assigned
Labels
chapter: linear-networks priority:high status: phase 2
Projects
No open projects
v0.14.x
  
Done (Max)
Milestone
03. Linear Neural Networks
Development

Successfully merging this pull request may close these issues.

Revise "softmax-regression-scratch_vn" - Phần 1
5 participants
@thanhcsf @tiepvupsu @ngcthuong @lkhphuc @minhduc0711