Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ammonite: 1.7.4 -> 2.0.4 #82855

Merged
merged 1 commit into from Mar 19, 2020
Merged

ammonite: 1.7.4 -> 2.0.4 #82855

merged 1 commit into from Mar 19, 2020

Conversation

fabianpage
Copy link
Contributor

@fabianpage fabianpage commented Mar 18, 2020 •
edited

Motivation for this change

update the ammonite shell to 2.0.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabianpage
Copy link
Contributor Author

sorry i didn't understood how to run the tests. I'm looking into them now.

@ofborg ofborg bot requested a review from NeQuissimus March 18, 2020 14:47
jonringer
jonringer reviewed Mar 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change commit message to:

ammonite: 1.7.4 -> 2.0.4

otherwise LGTM

[5 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82855
2 package built:
ammonite ammonite_2_12

@jonringer
Copy link
Contributor

https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

@fabianpage fabianpage changed the title ammonite: updated to version 2.0.4 ammonite: 1.7.4 -> 2.0.4 Mar 19, 2020
@fabianpage
Copy link
Contributor Author

thanks, sorry also didn't read that file.

@jonringer jonringer merged commit 1a78682 into NixOS:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabianpage @jonringer @Janik-Haag