Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flips: init at unstable-2020-10-02 #82860

Merged
merged 1 commit into from Oct 9, 2020
Merged

flips: init at unstable-2020-10-02 #82860

merged 1 commit into from Oct 9, 2020

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Mar 18, 2020 •
edited

Motivation for this change

Adding a package I'm going to use for ROM hacking purposes (and probably nobody else, but that ain't stopping me).

Update: "probably nobody else" turned out to be wrong, considering #94508 was created.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

evenbrenden
evenbrenden approved these changes Mar 28, 2020
View reviewed changes
Copy link
Contributor

@evenbrenden evenbrenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64 (Ubuntu 18.04)
  • package build on x86_64 (NixOS 19.09)
  • executables tested on x86_64 (Ubuntu 18.04)
  • executables tested on x86_64 (NixOS 19.09)
  • all depending packages build (Ubuntu 18.04)
  • all depending packages build (NixOS 19.09)

aanderse
aanderse requested changes Mar 28, 2020
View reviewed changes
pkgs/tools/compression/flips/default.nix Show resolved Hide resolved
pkgs/tools/compression/flips/default.nix Outdated Show resolved Hide resolved
pkgs/tools/compression/flips/default.nix Outdated Show resolved Hide resolved
@aanderse
Copy link
Member

@GrahamcOfBorg build flips

@KamilaBorowska
Copy link
Member Author

KamilaBorowska commented Mar 29, 2020 •
edited

Oops, accidentally requested a review. Oh well. Nothing did change as far build is concerned, the only changes since then were in meta section, so no rebuilds should be involved.

@aanderse
Copy link
Member

I might be missing something but this seems to crash on me with most options in the gui I choose.

@KamilaBorowska
Copy link
Member Author

KamilaBorowska commented Mar 29, 2020 •
edited

I might be missing something but this seems to crash on me with most options in the gui I choose.

Yeah, this is a weird one, this also happens for me. I think this may be related to https://discourse.nixos.org/t/firefox-crashes-when-opening-a-file-dialog/5323. If you are using release-19.09 of NixOS, cherry pick this commit to release-19.09 (for testing purposes) for file selection dialogs to work.

@evenbrenden
Copy link
Contributor

evenbrenden commented Apr 3, 2020 •
edited

Yeah, this is a weird one, this also happens for me. I think this may be related to https://discourse.nixos.org/t/firefox-crashes-when-opening-a-file-dialog/5323. If you are using release-19.09 of NixOS, cherry pick this commit to release-19.09 (for testing purposes) for file selection dialogs to work.

Tested this (on Ubuntu 18.04 and NixOS 19.09), works fine. Haven't had the opportunity to test the program properly with emulators and ROM creation, but can confirm that build, run and clicking around is all right.

@aanderse
Copy link
Member

aanderse commented Apr 6, 2020

I might be missing something but this seems to crash on me with most options in the gui I choose.

Yeah, this is a weird one, this also happens for me. I think this may be related to https://discourse.nixos.org/t/firefox-crashes-when-opening-a-file-dialog/5323. If you are using release-19.09 of NixOS, cherry pick this commit to release-19.09 (for testing purposes) for file selection dialogs to work.

Maybe our experts @jtojnar or @worldofpeace might have some insight into this.

@jtojnar
Copy link
Contributor

jtojnar commented Apr 6, 2020

GTK apps need to add wrapGAppsHook, see https://nixos.org/nixpkgs/manual/#sec-language-gnome.

Maybe also ask upstream to use git tags for releases.

@KamilaBorowska KamilaBorowska marked this pull request as draft April 9, 2020 08:28
@KamilaBorowska KamilaBorowska marked this pull request as ready for review April 10, 2020 17:41
@IvarWithoutBones IvarWithoutBones mentioned this pull request Aug 3, 2020
Closed
10 tasks
@KamilaBorowska
Copy link
Member Author

What is the status of merge request? By the way, about version tag, upstream refuses to tag 1.31 because "stop using four years old software when newer ones exist" and when asked about newer versions upstream pointed me to git master. I suppose I may as well try updating this to newest version on master then.

@KamilaBorowska KamilaBorowska changed the title flips: init at 1.31 flips: init at unstable-2020-07-14 Aug 23, 2020
@aanderse
Copy link
Member

ping @jtojnar for final review and merge.

@KamilaBorowska
Copy link
Member Author

@ofborg build flips

@KamilaBorowska KamilaBorowska changed the title flips: init at unstable-2020-07-14 flips: init at unstable-2020-10-02 Oct 6, 2020
@KamilaBorowska
Copy link
Member Author

Updated to unstable-2020-10-02.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/327

@Lassulus Lassulus merged commit 966a7e9 into NixOS:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenbrenden evenbrenden evenbrenden approved these changes

@aanderse aanderse Awaiting requested review from aanderse

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@KamilaBorowska @aanderse @evenbrenden @jtojnar @nixos-discourse @Lassulus