Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cura: Re-enable OpenMP. Fixes #59901. #82820

Closed
wants to merge 1 commit into from

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Mar 18, 2020

Motivation for this change

#59901 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

With the newer openblas version mentioned around
NixOS#59901 (comment)
this seems to work again.
@gebner
Copy link
Member

gebner commented Mar 18, 2020

I played a bit with it, and I still get corrupted meshes. This bug typically happens with large files, but unfortunately I can't reproduce it reliable. Sometimes it works, sometimes it doesn't. Here is a 150M STL file that triggers it almost every time: https://1drv.ms/u/s!Au1u53SHpLowjGhzY5Npp1DNAW6k?e=LYbvEk

@nh2
Copy link
Contributor Author

nh2 commented Mar 20, 2020

Sometimes it works, sometimes it doesn't.

@gebner

  1. Statistically how many times do you have to try to get corruption? Just so I know how much time to spend to repro it.
  2. Do you need to quit Cura in between?
  3. Is there an upstream bug report?

@stale
Copy link

stale bot commented Sep 16, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 16, 2020
@nh2
Copy link
Contributor Author

nh2 commented Sep 16, 2020

Still important, but knowing whether there's an associated upstream bug report would be very useful.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 16, 2020
@gebner
Copy link
Member

gebner commented Sep 16, 2020

Still important, but knowing whether there's an associated upstream bug report would be very useful.

I'm not aware of any upstream bug about this issue, or even what upstream is in this case:

  • Cura only accepts bugs that are reproducible with their appimage. And they build openblas without openmp, thereby avoiding this bug.
  • It's possible that the bug is due to how PyQt sets up threads, who knows?
  • The other options are scipy or openblas. However they likely want a small testcase triggering the bug (i.e. not involving cura). I simply don't have the time to minimize this in the foreseeable future.

Statistically how many times do you have to try to get corruption? Just so I know how much time to spend to repro it.

It happens more than 50% of the time, larger meshes are more likely to be corrupted.

Do you need to quit Cura in between?

No.

@stale
Copy link

stale bot commented Mar 16, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 16, 2021
@Artturin Artturin closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants