Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab: 12.8.6 -> 12.8.7 #82838

Merged
1 commit merged into from Mar 24, 2020
Merged

gitlab: 12.8.6 -> 12.8.7 #82838

1 commit merged into from Mar 24, 2020

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Mar 18, 2020

Motivation for this change

Update GitLab to the latest patch release.

Includes these fixes:

  • Fix/x509 signed commit
  • Allow packages multipart uploads

For more info, see the update blog post.

Things done
  • Tested locally in a VM

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

@talyz
Copy link
Contributor Author

talyz commented Mar 18, 2020

Seems like GitHub now requires commit access to allow assigning requests, and I don't have that, so: @flokli @petabyteboy

@ghost
Copy link

ghost commented Mar 24, 2020

Thanks, can you prepare backports for 20.03 and 19.09?

@ghost ghost merged commit 3a173c1 into NixOS:master Mar 24, 2020
@talyz
Copy link
Contributor Author

talyz commented Mar 25, 2020

Sure!

talyz added a commit to talyz/nixpkgs that referenced this pull request Mar 25, 2020
talyz added a commit to talyz/nixpkgs that referenced this pull request Mar 25, 2020
@talyz talyz deleted the gitlab-12.8.7 branch June 16, 2021 08:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant