Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syslinux: hardcode HEXDATE #82839

Closed
wants to merge 1 commit into from
Closed

syslinux: hardcode HEXDATE #82839

wants to merge 1 commit into from

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Mar 18, 2020 •
edited

This is one of many steps needed for syslinux reproducibility.

Motivation for this change

Improving reproducibility of syslinux. This doesn't make the package reproducible by itself, but is one of steps towards it. This working can be verified by opening /nix/store/nahfzrphghj68g2dpik5w0zk9yxqar3i-syslinux-2019-02-07/share/syslinux/memdisk in a hex editor - a constant string "0x5e71e89e" should be in it (a literal ASCII string).

000005b0: 4d45 4d44 4953 4b20 362e 3034 2030 7835  MEMDISK 6.04 0x5
000005c0: 6537 3165 3839 6500 ffff 0000 0000 0000  e71e89e.........
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska
Copy link
Member Author

@GrahamcOfBorg test boot

1 similar comment
@KamilaBorowska
Copy link
Member Author

@GrahamcOfBorg test boot

@ofborg ofborg bot requested a review from samueldr March 18, 2020 09:59
@KamilaBorowska
syslinux: hardcode HEXDATE
c9c0277 
This is one of many steps needed for syslinux reproducibility.
@KamilaBorowska KamilaBorowska force-pushed the improve-syslinux-reproducibility branch from e416998 to c9c0277 Compare March 19, 2020 11:20
@KamilaBorowska
Copy link
Member Author

@GrahamcOfBorg test boot

@ajs124 ajs124 mentioned this pull request Jun 29, 2020
Merged
10 tasks
@bjornfor
Copy link
Contributor

bjornfor commented Jul 2, 2020

Closing as this was done #91672.

@bjornfor bjornfor closed this Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr Awaiting requested review from samueldr

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KamilaBorowska @bjornfor @samueldr