Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.rpy2: fix tests with pandas 1.x, 3.2.5 -> 3.2.6 #82773

Merged
merged 2 commits into from Mar 17, 2020
Merged

python3.pkgs.rpy2: fix tests with pandas 1.x, 3.2.5 -> 3.2.6 #82773

merged 2 commits into from Mar 17, 2020

Conversation

timokau
Copy link
Member

@timokau timokau commented Mar 17, 2020 •
edited

Motivation for this change

The python3.pkgs.rpy2 build was broken by a recent update to pandas. A fix is already upstream and just needs to be backported. While I'm at it I also included a version bump to the latest released version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from joelmo March 17, 2020 11:09
@timokau timokau merged commit 4ad4523 into NixOS:master Mar 17, 2020
@timokau timokau deleted the rpy2-pandas-1.x branch March 17, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@joelmo joelmo Awaiting requested review from joelmo

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@timokau