Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualboxExtpack: synchronize version with virtualbox #82774

Merged
merged 1 commit into from Mar 18, 2020
Merged

virtualboxExtpack: synchronize version with virtualbox #82774

merged 1 commit into from Mar 18, 2020

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Mar 17, 2020

Motivation for this change

Since #82479 the virtualboxExtpack version is out of sync with virtualbox (6.0.14 vs 6.1.4).

This change synchronizes the virtualboxExtpack version with the virtualbox version.

The next time the packages are not updated in parallel building virtualboxExtpack will fail with a hash mismatch and therefore fail fast.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @m-scr @alyssais

@B4dM4n B4dM4n mentioned this pull request Mar 17, 2020
Merged
10 tasks
@cdepillabout
Copy link
Member

@B4dM4n Will the hash mismatch definitely be triggered here? (I know there is a big problem with hash mismatches not actually being caught because it is a fixed-output derivation.)

If so, this looks good to me.

@B4dM4n
Copy link
Contributor Author

B4dM4n commented Mar 17, 2020

@B4dM4n Will the hash mismatch definitely be triggered here? (I know there is a big problem with hash mismatches not actually being caught because it is a fixed-output derivation.)

Yes, the output contains the version in its name and source:

fetchurl rec {
  name = "Oracle_VM_VirtualBox_Extension_Pack-${version}.vbox-extpack";
  url = "https://download.virtualbox.org/virtualbox/${version}/${name}";
...

The change of version will trigger a download of the new file, which will be checked against the old sha256.

@cdepillabout cdepillabout merged commit ac0da76 into NixOS:master Mar 18, 2020
@cdepillabout
Copy link
Member

@B4dM4n Okay, looks good to me. Thanks!

@B4dM4n B4dM4n deleted the virtualbox-extpack-update branch March 18, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanderburg svanderburg Awaiting requested review from svanderburg

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@B4dM4n @cdepillabout