Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 071d0cc0cb0d
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 5f357b20b3b0
Choose a head ref
  • 4 commits
  • 3 files changed
  • 3 contributors

Commits on Mar 17, 2020

  1. lib/modules: Remove internal _module attribute from config 

    The _module option is added as an internal option set, and it messes up
the results of module evaluations, requiring people to manually filter
_modules out.

If people depend on this, they can still use config._module from inside
the modules, exposing _module as an explicitly declared user option. Or
alternatively with the _module attribute now returned by evalModules.
    @infinisil
    infinisil committed Mar 17, 2020
    Copy the full SHA
    dcdd232 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. lib/modules: Throw better error when definitions assign to an option set

    @infinisil
    infinisil committed Mar 18, 2020
    Copy the full SHA
    15c873b View commit details
    Browse the repository at this point in the history

  2. lib/modules: Fix type checks not being done before merging 

    Co-Authored-By: Robert Hensing <robert@roberthensing.nl>
    @infinisil @roberth
    infinisil and roberth committed Mar 18, 2020
    Copy the full SHA
    e931de5 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #82751 from Infinisil/minor-module-improvements 

    Minor module improvements
    @roberth
    roberth committed Mar 18, 2020
    Copy the full SHA
    5f357b2 View commit details
    Browse the repository at this point in the history