Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skypeforlinux: support app indicator #82828

Merged
merged 1 commit into from Mar 30, 2020
Merged

skypeforlinux: support app indicator #82828

merged 1 commit into from Mar 30, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

In contrast to e.g. Telegram or Slack, Skype does not show an app
indicator in the GNOME tray. This is quite annoying, since Skype will
continue to run in the background when its main window is closed, but
there is no way to access it.

This change adds libappindicator-gtk3 to the rpath to enable app
indicator support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
skypeforlinux: support app indicator
08d1c7e 
In contrast to e.g. Telegram or Slack, Skype does not show an app
indicator in the GNOME tray. This is quite annoying, since Skype will
continue to run in the background when its main window is closed, but
there is no way to access it.

This change adds libappindicator-gtk3 to the rpath to enable app
indicator support.
@ofborg ofborg bot requested review from PanAeon and jraygauthier March 18, 2020 07:18
@pschuprikov
Copy link
Contributor

One probably needs to use gnome3 to test the change since the legacy systray simply doesn't have the app indicator issue.

puzzlewolf
puzzlewolf approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@puzzlewolf puzzlewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

jraygauthier
jraygauthier approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@jraygauthier jraygauthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works fine on xfce.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/129

@Mic92 Mic92 merged commit ca9ea76 into NixOS:master Mar 30, 2020
@Mic92
Copy link
Member

Mic92 commented Mar 30, 2020

Also ported to 20.03: 42001e5

@danieldk danieldk deleted the skype-appindicator branch March 30, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jraygauthier jraygauthier jraygauthier approved these changes

@puzzlewolf puzzlewolf puzzlewolf approved these changes

@PanAeon PanAeon Awaiting requested review from PanAeon

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@danieldk @pschuprikov @nixos-discourse @Mic92 @jraygauthier @puzzlewolf