New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Add overrideAttrs attribute aliasing overridePythonAttrs #82772
Conversation
This will make lib.makeOverridable use overridePythonAttrs by default.
@FRidh What kind of tests do you have in mind? |
Testing that |
8089e70
to
4e3f282
Compare
@FRidh I added a test. Since it's not actually building anything but only asserts attributes I made a new type of test. |
4e3f282
to
d117f06
Compare
@GrahamcOfBorg build python2.tests python3.tests python38.tests |
@GrahamcOfBorg build pypy2.tests pypy3.tests |
Let's wait a bit with merging this. |
@FRidh yiu don’t think this needs an RFC any more? |
Right, I wrote that. I do think it is best we standardize interfaces like these and I see you asked matthewbauer at the time to help with it. Let's write a small RFC and see where that takes us. |
RFC proposal #46842 (comment) |
Not sure about this, because we already have a bunch of override mechanisms which all work slightly differently. And by doing this it gets even more complex because it mixes ones name with anothers behavior. But then again, python packages accept pretty much all arguments of |
Closing, see NixOS/rfcs#67. |
Motivation for this change
This will make lib.makeOverridable use overridePythonAttrs by default.
Overriding Python packages has some surprising properties unless you use
overridePythonAttrs
and it can be incredibly frustrating to try and find out why that is.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)