Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opensmtpd: 6.4.2p1 -> 6.6.4p1 [backport 19.09] #82775

Merged
merged 7 commits into from Mar 17, 2020
Merged

opensmtpd: 6.4.2p1 -> 6.6.4p1 [backport 19.09] #82775

merged 7 commits into from Mar 17, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 17, 2020 •
edited

Motivation for this change

The current version of opensmtpd contains a remote code execution bug and was therefore marked as insecure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

flokli and others added 7 commits March 17, 2020 12:04
@flokli @Mic92
opensmtpd: 6.4.2p1 -> 6.6.1p1
7db6a85 
The substitition in smtpd/parse.y isn't necessary anymore.
The hardcoded /usr/libexec/ has been replaced by a PATH_LIBEXEC #define,
which will be set properly by the build system.

(cherry picked from commit 9658850)
@fpletz @Mic92
opensmtpd: 6.6.1p1 -> 6.6.2p1
3ecd571 
Fixes critical vulnerability:
  https://www.mail-archive.com/misc@opensmtpd.org/msg04850.html

(cherry picked from commit 7b9bd59)
@r-ryantm @Mic92
opensmtpd: 6.6.2p1 -> 6.6.3p1
7a106bd 
(cherry picked from commit 77da495)
@andir @Mic92
opensmtpd: 6.6.3p1 -> 6.6.4p1
521c676 
Release notes aren't available at this time [1] it is likely to be
related to a recent mail to oss-security (either [2] or [3]).

[1] https://www.mail-archive.com/misc@opensmtpd.org/msg04888.html
[2] https://www.openwall.com/lists/oss-security/2020/02/24/5
[3] https://www.openwall.com/lists/oss-security/2020/02/24/4

(cherry picked from commit 09725e5)
@Mic92
Revert "opensmtpd: mark as insecure due to CVE-2020-8794 / NixOS#80978"
ce282f0 
This reverts commit 4f69f2c.

We backported the latest opensmtpd version.
@Mic92
Revert "opensmtpd: apply patch for CVE-2020-7247.patch"
fe67f42 
This reverts commit f5c74e6.

Already included in the opensmtpd version.
@Mic92
opensmtpd: build against openssl
29431a0 
build fails against our local libressl version
@Mic92
Copy link
Member Author

Mic92 commented Mar 17, 2020

@GrahamcOfBorg test opensmtpd

@Mic92 Mic92 mentioned this pull request Mar 17, 2020
Merged
@Mic92 Mic92 requested a review from flokli March 17, 2020 12:13
@ofborg ofborg bot requested review from obadz, rickynils and Ekleog March 17, 2020 12:17
@obadz obadz merged commit bf7c0f0 into NixOS:release-19.09 Mar 17, 2020
@Mic92 Mic92 deleted the opensmtpd-backport branch March 17, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

@obadz obadz Awaiting requested review from obadz

@rickynils rickynils Awaiting requested review from rickynils

@Ekleog Ekleog Awaiting requested review from Ekleog

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Mic92 @obadz @flokli @fpletz @r-ryantm @andir