Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tor-browser-bundle-bin: enable multimedia support by default #82807

Merged
merged 1 commit into from Mar 29, 2020
Merged

tor-browser-bundle-bin: enable multimedia support by default #82807

merged 1 commit into from Mar 29, 2020

Conversation

mehlon
Copy link
Contributor

@mehlon mehlon commented Mar 17, 2020 •
edited

Motivation for this change

Fixes #82597
Fixes #82594

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
Copy link
Member

Check the impact on closure size please.

@mehlon
Copy link
Contributor Author

mehlon commented Mar 18, 2020

nix path-info -S closure size:
Before:
/nix/store/igl0s3kbwbw4qsli2ddddhchh358mjw3-tor-browser-bundle-bin-9.0.6 635461480
After:
/nix/store/5lkqlc017p58vnjvm34vk78zkzwkwkzc-tor-browser-bundle-bin-9.0.6 696314464

Ma27
Ma27 approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The closure size impact seems justifiable for a GUI application IMHO. What do you think @alyssais? :)

@mehlon
Copy link
Contributor Author

mehlon commented Mar 21, 2020 •
edited

It appears this version has a bug. When the Tor Browser starts, some add-ons might be disabled, including NoScript. To replicate: set the security level to "Safest" (which disables Javascript) then check https://enable-javascript.com/ which says whether Javascript is enabled.
Try this with both the version before and after enabling multimedia.
This needs to be investigated before merging. It might even be a problem upstream.

@mehlon
Copy link
Contributor Author

mehlon commented Mar 21, 2020 •
edited

Actually, it seems to have been introduced in 9.0.6, not this pull request #83096
That means this pull request is still ready to merge.

@alyssais
Copy link
Member

The closure size impact seems justifiable for a GUI application IMHO. What do you think @alyssais? :)

Agreed.

@flokli flokli merged commit ae39289 into NixOS:master Mar 29, 2020
@flokli flokli mentioned this pull request Apr 10, 2020
Closed
@mehlon mehlon deleted the tor-browser branch April 11, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tor Browser: can't play audio/video streams Tor Browser: doesn't show search engine thumbnails
4 participants
@mehlon @alyssais @Ma27 @flokli